CFM-103_LDAP_server_mvc #374
Conversation
Ioannis
force-pushed
the
CFM-103_LDAP_server_mvc
branch
from
c991c60 to
cd5cdbd
Compare
|
|
Ioannis
force-pushed
the
CFM-103_LDAP_server_mvc
branch
from
cd5cdbd to
c31a514
Compare
Ioannis
force-pushed
the
CFM-103_LDAP_server_mvc
branch
2 times, most recently
from
7a63755 to
05b735c
Compare
Ioannis
force-pushed
the
CFM-103_LDAP_server_mvc
branch
2 times, most recently
from
af9faba to
ea8ac7d
Compare
Ioannis
force-pushed
the
CFM-103_LDAP_server_mvc
branch
4 times, most recently
from
dd66827 to
4293765
Compare
Ioannis
force-pushed
the
CFM-103_LDAP_server_mvc
branch
3 times, most recently
from
1b2ec09 to
bf616a2
Compare
Ioannis
force-pushed
the
CFM-103_LDAP_server_mvc
branch
2 times, most recently
from
179d6da to
66621fa
Compare
Ioannis
force-pushed
the
CFM-103_LDAP_server_mvc
branch
4 times, most recently
from
4fe0400 to
ef65098
Compare
Ioannis
force-pushed
the
CFM-103_LDAP_server_mvc
branch
from
ef65098 to
d9b0ace
Compare
| * | ||
| * @param EventInterface $event Cake Event | ||
| * @return \Cake\Http\Response|null|void | ||
| * @since COmanage Registry v5.2.0 |
| return true; | ||
| } | ||
| } catch (\Exception $e) { | ||
| Log::error(__METHOD__ . "::Connection test '{$name}' failed: " . $e->getMessage()); |
There was a problem hiding this comment.
If you use LabeledLogTrait::llog it'll automatically insert function call information in a standard way
| * @throws \InvalidArgumentException If non-delete and $newDn is missing. | ||
| * @throws \RuntimeException On LDAP failures not handled by fallback. | ||
| */ | ||
| public function applyProvisioningPlan( |
There was a problem hiding this comment.
I realize this is a bit of a grey area, but I think there's a question as to how much of this belongs here and how much belongs in the LDAP Provisioner.
For comparison, the other Server models tend to be pretty thin, providing basic configuration and connectivity, and maybe functions that map pretty close to the wire protocol. For example, SmtpServer doesn't have any support functions (those are implemented in DeliveryUtilities), while MatchServer basically has function calls that perform the Match API requests.
| * Performs a case-insensitive suffix match. If $baseDn is empty or not a suffix | ||
| * of $newDn, returns $newDn unchanged. | ||
| */ | ||
| protected function computeRelativeRdn(string $newDn, string $baseDn): string { |
There was a problem hiding this comment.
"Relative RDN" is like "ATM Machine" :)
| $context['diagnostic_message'] = $err; | ||
| } | ||
|
|
||
| Log::error(__METHOD__ . "::LDAP error during $functionName", $context); |
There was a problem hiding this comment.
Like above, maybe use LabeledLogTrait?
| if ($connection) { | ||
| $this->Flash->success(__d('operation', 'rs.test.ok')); | ||
| Log::debug("Successfully connected to server " . $serverId); |
| try { | ||
| if (method_exists($pluginTable, 'checkConnectivity')) { | ||
| // Set the Connection Manager config |
| 'controller' => 'Servers', | ||
| 'action' => 'index', | ||
| '?' => [ | ||
| 'co_id' => $serverObj->co_id | ||
| ] | ||
| ]; | ||
|
|
||
| // Redirect to the referring page, with a fallback to the Servers index | ||
| return $this->redirect($this->referer($fallbackRedirectToIndexPage)); |
There was a problem hiding this comment.
Why not just use generateRedirect()?
| [ | ||
| 'action' => 'testconnection', | ||
| 'label' => __d('operation', 'connection.test'), | ||
| 'icon' => 'fact_check' |
There was a problem hiding this comment.
Oh I think we're going to need to have a meeting to discuss icon selection
| msgstr "Failed to connect to LDAP server {0}" | ||
|
|
||
| msgid "error.LdapServers.credentials" | ||
| msgstr "Missing authentication credentials for LDAP server {0}" | ||
|
|
||
| msgid "error.LdapServers.serverurl.valid" | ||
| msgstr "Please enter a valid ldap or ldaps URL (e.g., ldaps://server:port)" | ||
|
|
||
| msgid "field.LdapServers.serverurl" | ||
| msgstr "Server URL" | ||
|
|
||
| msgid "field.LdapServers.serverurl.desc" | ||
| msgstr "LDAP server URL, e.g. ldap://ldap.example.org or ldaps://ldap.example.org" |
There was a problem hiding this comment.
The messages should be grouped together as the rest of the file is grouped, so error messages with other error messages, field messages with other field messages, etc.
…hods supports from the ldap server. Fixed ldap connection cache.
… Add more LdapCommon codes.
Ioannis
force-pushed
the
CFM-103_LDAP_server_mvc
branch
from
d9b0ace to
fdaf7c3
Compare
2 participants
No description provided.